Better Flash version detection

gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash

BSD 3-Clause "New" or "Revised" License

2.73k stars 489 forks source link

Better Flash version detection #72

Closed doenietzomoeilijk closed 13 years ago

doenietzomoeilijk commented 13 years ago

Hi,

My Linux box didn't get it's Flash version detected correctly; it's supposed to be 10.1 but I still got the error stating I'd need >=10.0. This change does return the correct major version.

gimite commented 13 years ago

What is returned by swfobject.getFlashPlayerVersion() in your environment? Looking at source code of hasFlashPlayerVersion(), it looks it should work fine.

doenietzomoeilijk commented 13 years ago

Yeah, I should've been more clear in my pull request.

In my environment (Debian, Iceweasel, Gnash):

swfobject.hasFlashPlayerVersion() returns a type error ("Z is undefined")
swfobject.hasFlashPlayerVersion("10.0.0") (as used) returns false.
swfobject.getFlashPlayerVersion() returns {major: 10, minor: 0, release: NaN}.

gimite commented 13 years ago

Pulled. It looks like a bug in swfobject that it cannot detect release version of Gnash. It would be nice to report the bug to swfobject library.