search

gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash
BSD 3-Clause "New" or "Revised" License
2.73k stars 489 forks source link

build.xml #86

Closed ghost closed 13 years ago

ghost commented 13 years ago

I removed the xml decleration line <XML: as it as creating errors.

I changed the swc build to exclude 'static' files, to avoid class verify errors.

gimite commented 13 years ago

Can you send a pull request?

Also, what's your build environment? I haven't seen errors with my environment (Flex 4 SDK).

ghost commented 13 years ago

When I build on mac, the <xml ... line gave me errors, I deleted.

The swc static files=false makes the swc smaller and avoid class verification errors if the same class (ex: mx. util) is used in other parts of people projects.

I am not good in git, it will take me a bit to commit those 2 lines of change.

gimite commented 13 years ago

When I build on mac, the <xml ... line gave me errors, I deleted.

I found that I should not put comment before <?xml... line. It seems I haven't tested it after I added the comment... Thanks for the report. Fixed with: https://github.com/gimite/web-socket-js/commit/efec7adc76d8905c5fec001e5eef89e0c85e09b9

The swc static files=false makes the swc smaller and avoid class verification errors if the same class (ex: mx. util) is used in other parts of people projects.

I still don't understand how to make this change. You mean static-link-runtime-shared-libraries="false"? It would be nice if you send me your actual change in some format (e.g. diff or whole file after the change).

ghost commented 13 years ago

Yes, line 57 static-link-runtime-shared-libraries="true"> to false.

gimite commented 13 years ago

Thanks. Fixed with https://github.com/gimite/web-socket-js/commit/ed0622a890de811eb6d766d5c5a9a62d726f0593