gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash
BSD 3-Clause "New" or "Revised" License
2.73k stars 489 forks source link

No error / close callback called when socket is invalidated #92

Closed jpcarlino closed 12 years ago

jpcarlino commented 12 years ago

I'm not completely sure if this is a collateral problem but from the tests i've performed it seems that a flash exception is thrown when the websocket is invalidated before any javascript callback has been called.

My application sends a keepalive packet every 30 seconds to the server. If I suddenly stop the server while connection is in progress, first of all, the client doesn't notice it (no event is triggered by flash bridge). Second, when the heartbeat is sent, flash bridge throws this error:

Error calling method on NPObject!

the javascript line in question is the send function, as expected:

var result = WebSocket.__flash.send(this.__id, encodeURIComponent(data));

looking into flash debugger i see:

Error: Error #2002: Operation attempted on invalid socket.
at flash.net::Socket/flush()
at com.hurlant.crypto.tls::TLSSocket/flush()
at net.gimite.websocket::WebSocket/send()
at net.gimite.websocket::WebSocketMain/send()
at Function/http://adobe.com/AS3/2006/builtin::apply()
at flash.external::ExternalInterface$/_callIn()
at Function/<anonymous>()

so, in short, when socket is invalidated (for example, connection broken) no event is triggered, and it seems i can't catch that error. Any clue?

gimite commented 12 years ago

Thanks for the report. How do you "suddenly stop the server"? I use em-websocket and tried to kill it with kill -INT and kill -KILL but I couldn't reproduce it (onclose event fires as usual). Probably it can happen when the client somehow doesn't notice the socket close immediately, but noticed that when it tries to send something? I'm thinking of firing "error" event on exception in send().

gimite commented 12 years ago

Committed a change to fire close event on exception in send(). I cannot reproduce the situation, but hopefully it works.