search

gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash
BSD 3-Clause "New" or "Revised" License
2.73k stars 489 forks source link

wasClean #96

Closed dvv closed 12 years ago

dvv commented 12 years ago

Hi!

Wonder if you could add wasClean property to CloseEvent, which would denote whether close was orderly or not? Just as native WebSocket implementation does.

TIA, --Vladimir

dvv commented 12 years ago

Please, consider applying the fix: https://gist.github.com/1232284

gimite commented 12 years ago

Thanks for the patch. But it seems the patch misses the change to web_socket.js. Also, it would be nicer, but optional, to use Github's pull request feature.

dvv commented 12 years ago

Will do

dvv commented 12 years ago

Done -- the three pending pull requests. (sorry, have only web https access) Please, consider applying

gimite commented 12 years ago

Can you merge the requests into one request?

dvv commented 12 years ago

Needa explore how to do this. Usually I do fork, make offline changes and then push in one go...

gimite commented 12 years ago

You can do that by applying all changes in one branch (rather than creating three branches) and click "pull request" for the branch.

dvv commented 12 years ago

I did "Fork and edit" via github

dvv commented 12 years ago

lemme redo

dvv commented 12 years ago

https://github.com/gimite/web-socket-js/pull/100 -- this number is better ;)

gimite commented 12 years ago

Thanks, now the request looks fine. I'll look into it.

gimite commented 12 years ago

Pulled partially and implemented in a bit different way because I also wanted to add code and reason. https://github.com/gimite/web-socket-js/commit/55ae639a2ee607dea2ba40df608588f1b840a9cc