Closed dvv closed 12 years ago
Please, consider applying the fix: https://gist.github.com/1232284
Thanks for the patch. But it seems the patch misses the change to web_socket.js. Also, it would be nicer, but optional, to use Github's pull request feature.
Will do
Done -- the three pending pull requests. (sorry, have only web https access) Please, consider applying
Can you merge the requests into one request?
Needa explore how to do this. Usually I do fork, make offline changes and then push in one go...
You can do that by applying all changes in one branch (rather than creating three branches) and click "pull request" for the branch.
I did "Fork and edit" via github
lemme redo
https://github.com/gimite/web-socket-js/pull/100 -- this number is better ;)
Thanks, now the request looks fine. I'll look into it.
Pulled partially and implemented in a bit different way because I also wanted to add code and reason. https://github.com/gimite/web-socket-js/commit/55ae639a2ee607dea2ba40df608588f1b840a9cc
Hi!
Wonder if you could add
wasClean
property toCloseEvent
, which would denote whether close was orderly or not? Just as native WebSocket implementation does.TIA, --Vladimir