gimlet-io / capacitor

A general purpose UI for FluxCD.
Apache License 2.0
476 stars 13 forks source link

Providing a helm chart #84

Open tropnikovvl opened 2 months ago

tropnikovvl commented 2 months ago

Hello! Thanks for a great product!

It would be great to add a helm chart with versioning for its deployment. For example, I now want to add my own labels, annotations, ingress or security policies and it’s not entirely clear how to do this.

Also, versioning would help me create automatic testing pipelines in different environments when releasing a new version.

Thank you!

laszlocph commented 2 months ago

Hello @tropnikovvl

Capacitor does not need elaborate manifests to be deployed. The only requirement, is the proper RBAC so it can gather the data.

own labels, annotations, ingress or security policies

My take on providing a Helm chart is a bit controversial perhaps, but I believe maintaining a Helm chart to be able to configure every possible knob of Kubernetes is not the best way to spend time. Of course I can be convinced otherwise, or if someone made a Helm chart already i can link to it, but I don't want to maintain that as of now.

Maybe using https://fluxcd.io/flux/components/kustomize/kustomizations/#patches on https://github.com/gimlet-io/capacitor?tab=readme-ov-file#flux would be a way to provide labels/annotations? Ingress and policies can be stored as standalone files.

dshershov commented 2 months ago

hi, @laszlocph Helm is a widely used tool that people are used to working with. I really don't know how I can modify this service with some modifies and helm templates can help me with that Of course, you are not obliged to follow "the usual methods" or something like that, but I think that this request about providing a helm chart will come not only from the two of us Thanks!

sebastiangaiser commented 1 month ago

@laszlocph I started writing a Helm chart. For me question is now, do you want to have it as PR or should I publish it under my name?

sebastiangaiser commented 1 month ago

I published my Helm chart now: https://github.com/sebastiangaiser/helm-charts/releases/tag/capacitor-0.1.0 Feel free to give me feedback/PRs on it.

@laszlocph in case you're interested in merging it "upstream" or adding a link, please let me know