search

gimlet-io / capacitor

A general purpose UI for FluxCD.
Apache License 2.0
563 stars 17 forks source link

Kustomization breaks UI #99

Open SorsOps opened 5 months ago

SorsOps commented 5 months ago

This line is causing a break in the UI when I navigate to kustomizations and causing the entire UI to crash

https://github.com/gimlet-io/capacitor/blob/d8c8bc95c5af71ddf8baabc71da744dde9dcbc0c/web/src/Kustomization.jsx#L29

I have one kustomization that is in an error state that is the likely culprit, but I don't expect the entire App to crash if this happens,

We should add an error boundary for cases like this to prevent the entire UI from crashing and also in the case that a kustomization is in an errored state

jonasbadstuebner commented 4 months ago

https://github.com/gimlet-io/capacitor/blob/d8c8bc95c5af71ddf8baabc71da744dde9dcbc0c/web/src/OCIArtifactWidget.jsx#L8

also breaks the UI with the Console saying

TypeError: undefined has no properties

So without further debugging it, I guess the Status in line 6 has no property artifact.