search

gimli-rs / gimli

A library for reading and writing the DWARF debugging format
https://docs.rs/gimli/
Apache License 2.0
853 stars 108 forks source link

Support for setting CIE augmentation strings #608

Open akirilov-arm opened 2 years ago

akirilov-arm commented 2 years ago

Currently (as of commit 6edacd2b59a1c586d971d6eaa7929fb26e2aa9c7) when writing Common Information Entries there is no way to set an augmentation string directly; there is only a way to use a limited set of values indirectly. Support for setting CIE augmentation strings is important when using the Memory Tagging and/or Pointer Authentication extensions to the Arm architecture.

bjorn3 commented 2 years ago

Would it make sense to add two bool fields for augmentation characters?

philipc commented 2 years ago

I think these augmentation extensions are something that we need to add explicit support for, rather than letting you directly set the string, because some augmentation characters require special handling. So yes, adding bool fields for these makes sense to me.

It appears we also need to add read support for these.

akirilov-arm commented 2 years ago

Would it make sense to add two bool fields for augmentation characters?

Either option looks fine to me.