search

gimli-rs / gimli

A library for reading and writing the DWARF debugging format
https://docs.rs/gimli/
Apache License 2.0
846 stars 108 forks source link

Fix 'hidden lifetime parameters in types are deprecated' #713

Closed Enselic closed 5 months ago

Enselic commented 5 months ago

I am messing around with Rust's standard library and gimli. In my particular setup, Rust's build system tries to build gimli in a way that can be simulated like this:

cargo rustc --  -Wrust_2018_idioms -Wunused_lifetimes -Dwarnings

When build that way, the master branch fails with a bunch of errors like this:

error: hidden lifetime parameters in types are deprecated

This PR fixes that.

Enselic commented 5 months ago

Thanks for review. I have now enabled it as a warning and also updated tests (so that there is no warning emitted when running cargo test).