Closed mstange closed 6 months ago
I'm happy to see this change.
I don't understand the CI failure - is it compiling a mix of the crates.io version of object and the code in the repo?
It seems to be testing this PR merged with master
. I wasn't aware github actions did that. I think you need to rebase and fix the error.
Do you want to try rebasing this?
Oh right! Yes, doing that now.
The
Object
trait currently is defined as follows:It would be nicer if it were just this:
The
'file
lifetime in the trait parameters is rather cumbersome to work with. I think it's only there because pre-1.65 versions of Rust didn't let you use associated traits which are generic over a lifetime.If we're ready to make 1.65 the MSRV, then I think it's worth dropping this lifetime so that it's easier to write generic code which uses the
Object
trait. Here's a PR which implements that change.This isn't blocking anything for me at the moment but it would allow some code cleanup.