search

gimm / gulp-live-server

serve your nodejs/static app live
148 stars 71 forks source link

Fix behaviour of the promise returned by server.start() #6

Closed x-cray closed 9 years ago

x-cray commented 9 years ago

Currently, returned promise resolves immediately after first 'data' event which in my opinion is not correct — you simply can not get further output from child process. This PR makes use of deferred.notify instead of deferred.resolve for child process output forwarding purposes and resolves promise only when process exits.

x-cray commented 9 years ago

I'll fix unit tests and update PR =)