search

gimseng / 99-ML-Learning-Projects

A list of 99 machine learning projects for anyone interested to learn from coding and building projects
MIT License
576 stars 174 forks source link

Added Resources for Linear Regression #60

Closed AjayKhalsa closed 3 years ago

AjayKhalsa commented 3 years ago

@gimseng should I remove this and add this in the linear-regression branch instead.

gimseng commented 3 years ago

@ajaykhalsa thanks for the contribution ! Actually it was good that you did a new PR to include resources. Its good practice because we probably want to have a few rounds of work on an exercise/solution, and documentations and better instructions (including resources) are natural second stage of the process.

One thing just for future reference, do create a new (non master) branch in your own fork. I had similar comment in https://github.com/gimseng/99-ML-Learning-Projects/pull/46#issuecomment-661684417 as well in case that helps.

I will review your PR maybe in the next two days, hopefully at least another person could do that as well.

AjayKhalsa commented 3 years ago

@gimseng Thanks I'll make sure to create a branch in my fork next time.

gimseng commented 3 years ago

@AjayKhalsa I move the resources and links to the readme.md in the exercise folder's readme. Otherwise, looks great ! As far as I am concerned, its good to merge.

@Ar-Kareem if you are interested to review the resources and merge the PR, feel free to go ahead. Otherwise, anyone else in the core (that's not the original PR requestor) should go ahead and review and merge when satisfied.

gimseng commented 3 years ago

@AjayKhalsa Could you provide a short descriptions on each video link? Doesn't have to be too long, but at least the learners would know what are the different videos about, and in which order does one should go through them. Superficially, it seems like there are overlaps between videos, hence a small descriptions to highlight which videos teach what best would be useful.

AjayKhalsa commented 3 years ago

Sure will do @gimseng

gimseng commented 3 years ago

Thanks @AjayKhalsa !

gimseng commented 3 years ago

Hey, what's the status on this PR? It seems like its about a month since it opened, I'm tempted to include whatever updates we have so far and close this PR and create another issue on things remain to be done.

@AjayKhalsa, do you have any uncommitted work ?

AjayKhalsa commented 3 years ago

@gimseng Sorry was busy with a project, just added the descriptions for the links. Check it out and let me know if any changes are required

gimseng commented 3 years ago

Thanks @AjayKhalsa ! I will merge and close this PR. Thank you everyone for the help !