search

gimseng / 99-ML-Learning-Projects

A list of 99 machine learning projects for anyone interested to learn from coding and building projects
MIT License
576 stars 174 forks source link

Titanic subtask #72

Closed zeina99 closed 3 years ago

zeina99 commented 3 years ago

Reference Issues/PRs

Fixes #71

What does this implement/fix? Explain your changes.

Adding subtasks to exercise 001

Any other comments?

Thoughts on this? are tasks too specific?

aarpit1010 commented 3 years ago

This idea looks good. But do you think we should create another Jupyter notebook writing a few commands and leave the rest for them to fill up or do you want to make changes in my original solution ?

My personal recommendation would be to create an exercise in another jupyter notebook which would be almost same as the solution except for a few blank codes.

zeina99 commented 3 years ago

Yes I also prefer creating another jupyter notebook as some sort of template which they can follow and then have them go ahead and compare it to your solution.

So my understanding is that the template would be similar to your solution in terms of the steps done. The task would be written and they would have to write some code to achieve the task, correct?

aarpit1010 commented 3 years ago

Yes I also prefer creating another jupyter notebook as some sort of template which they can follow and then have them go ahead and compare it to your solution.

So my understanding is that the template would be similar to your solution in terms of the steps done. The task would be written and they would have to write some code to achieve the task, correct?

Yeas, I think that's a good option. Also, I would like you to include more plots and figures if possible as they are a bit less in the solution notebook.

zeina99 commented 3 years ago

Alright sounds great! I will get started on it and hopefully it will be done in a week or less

gimseng commented 3 years ago

@aarpit1010 and @zeina99 thanks for taking care of this. I'm glad that organic discussions and improvements are undergoing. Thanks !

zeina99 commented 3 years ago

I haven't added much code in the starter notebook as I figured they are probably not complete beginners and they probably have some idea on what to do, so I thought tasks would be enough.

Though I am open for suggestions or if anyone thinks otherwise!

gimseng commented 3 years ago

@zeina99 Thanks for the contribution ! I cleaned up a bit, mainly typos/capitalization and wordings, plus a few path links and stuff. Otherwise, looks great ! I'll merge now.