search

gimseng / 99-ML-Learning-Projects

A list of 99 machine learning projects for anyone interested to learn from coding and building projects
MIT License
576 stars 174 forks source link

Sentiment analysis #75

Closed tejasvi541 closed 3 years ago

tejasvi541 commented 3 years ago

68 Reference Issues/PRs

1. Added Correct Format for submission

2. Linked PR to the issue #68

gimseng commented 3 years ago

Hi @tejasvi541 thanks for the contribution.

I'll merge immediately but I have updated a few things, just for reference:

  1. Cleaned up the naming and folder conventions

  2. Instead of using open to open files, I changed it to using urllib.request.urlopen. Somehow open doesn't take into raw GitHub json files well and threw errors. I suspect its because its not reading it as plain text.

  3. I'll add a readme.md later on after I merge to update colab and nbviewer links.

@tejasvi541 Again, thanks for the contribution, the solution looks great !

tejasvi541 commented 3 years ago

Hi @gimseng , Thanks much for the update, glad to hear about the merge. As this is my first contribution to any open source project so I was a bit struggling with the git (newbie), but i managed it somehow. In future i will try to add more exercises and solutions to this Repo. Thanks again.

gimseng commented 3 years ago

@tejasvi541 Thanks for the contribution! More than the python codes, my original idea/goal for this repo is for people to start getting familiar with gits and code reviews. I hope that this helps you to get started !