search

gimseng / 99-ML-Learning-Projects

A list of 99 machine learning projects for anyone interested to learn from coding and building projects
MIT License
576 stars 174 forks source link

[IMP] 005 sentiment analysis missing codes #76

Closed gimseng closed 3 years ago

gimseng commented 3 years ago

The notebook seems to have some missing codes at the end regarding distributing positive and negative reviews.

@tejasvi541 Could you take a look since you last worked on it? Please fork the current/updated master file and add your codes to the end, if you have them. Thanks !

tejasvi541 commented 3 years ago

Hey @gimseng , The notebook is complete from my side, the mentioning the distribution of positive and negative reviews i have written at the end is actually completed by me in the above cells where i defined the Review Container class in cell number 8. As it was added by me in last steps so i wrote the description about it in the end. Thank you.

gimseng commented 3 years ago

@tejasvi541 Thanks for the reply. From my side (and checking out the original version in your PR), the nb ends with We will add one more container class above which will evenly distribute the positives and negatives in cell 8.

From your side, are there more codes after that? If yes, could you add to the current version on the repo? If no, then I don't quite understand the last sentence of the nb. I saw train_container and test_container being defined, but weren't used at all. I assume that after the last sentence, you might want to do train and evaluation using these two evenly-distributed data. Or do you want to leave as an exercise for the reader?

p/s: I dug further into your previous PR (#69), the nb seems to end in the sentence I mentioned above. Maybe there's some typo/accidental omissions of codes when you sync with your fork?

tejasvi541 commented 3 years ago

Hi @gimseng , I will have a look to the notebook again thoroughly and will make the desired changes which you have mentioned, incase I would not make that issue resolve , I will let you know about that. Thanks..