search

gin-contrib / cache

Gin middleware/handler to enable Cache
https://gin-gonic.github.io/gin
MIT License
378 stars 96 forks source link

Remove debugging #22

Closed SilverCory closed 6 years ago

SilverCory commented 6 years ago

Maybe add a header for an X-Gin-Cache-Miss if it's a miss error?

It just produces unnessicairy spam in the log.

On second thought maybe only remove it if it's a miss error also..

appleboy commented 6 years ago

https://travis-ci.org/gin-contrib/cache/jobs/347606578

./cache.go:146: undefined: ErrCacheMiss
appleboy commented 6 years ago

any updates?

SilverCory commented 6 years ago

Sorry, I meant to do this prior

codecov-io commented 6 years ago

Codecov Report

Merging #22 into master will increase coverage by 0.29%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   71.79%   72.09%   +0.29%     
==========================================
  Files           1        1              
  Lines          78       86       +8     
==========================================
+ Hits           56       62       +6     
- Misses         20       21       +1     
- Partials        2        3       +1
Impacted Files Coverage Δ
cache.go 72.09% <33.33%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 392dcc5...7eb62b8. Read the comment docs.