gin-contrib / cors

Official CORS gin's middleware
https://gin-gonic.github.io/gin/
MIT License
1.79k stars 186 forks source link

Modify the OPTIONS response status code #41

Closed li-keli closed 6 years ago

li-keli commented 6 years ago

Using 204 is better than 200 when the request status is OPTIONS

appleboy commented 6 years ago

build fail.

codecov-io commented 6 years ago

Codecov Report

Merging #41 into master will increase coverage by 1.67%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #41      +/-   ##
=========================================
+ Coverage   91.12%   92.8%   +1.67%     
=========================================
  Files           3       3              
  Lines         124     139      +15     
=========================================
+ Hits          113     129      +16     
+ Misses         11      10       -1
Impacted Files Coverage Δ
config.go 100% <ø> (+2.27%) :arrow_up:
cors.go 77.27% <0%> (+11.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6653abe...51c5124. Read the comment docs.