search

gin-contrib / cors

Official CORS gin's middleware
https://gin-gonic.github.io/gin/
MIT License
1.79k stars 186 forks source link

update go mod #53

Closed fifsky closed 5 years ago

fifsky commented 5 years ago

I upgrade gin to v1.4.0

But because of the dependence for library github.com/ugorji/go/codec incompatible, lead to can't use, so you need to update go.mod file

build app: cannot load github.com/ugorji/go/codec: ambiguous import: found github.com/ugorji/go/codec in multiple modules:
        github.com/ugorji/go v1.1.4 (/Users/fifsky/go/pkg/mod/github.com/ugorji/go@v1.1.4/codec)
        github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2 (/Users/fifsky/go/pkg/mod/github.com/ugorji/go/codec@v0.0.0-20181209151446-772ced7fd4c2)
codecov-io commented 5 years ago

Codecov Report

Merging #53 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files           3        3           
  Lines         172      172           
=======================================
  Hits          160      160           
  Misses         11       11           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd1331c...e30a911. Read the comment docs.

zzjin commented 5 years ago

+1

solarhell commented 5 years ago

image Still have the same issue.

fifsky commented 5 years ago

@thinkerou Can you create a release version? thanks

thinkerou commented 5 years ago

@fifsky done!