search

gin-contrib / logger

Gin middleware/handler to logger url path using rs/zerolog
MIT License
192 stars 35 forks source link

Bugs/isatty hot path #51

Closed cedric-appdirect closed 1 year ago

cedric-appdirect commented 1 year ago

Removing isatty call from the hot path significantly improve performance when using gin and zerolog via gin-contrig/logger.

appleboy commented 1 year ago

move to https://github.com/gin-contrib/logger/

codecov-commenter commented 1 year ago

Codecov Report

Merging #51 (b7b9aca) into master (809ceee) will decrease coverage by 0.03%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   97.52%   97.50%   -0.03%     
==========================================
  Files           2        2              
  Lines         121      120       -1     
==========================================
- Hits          118      117       -1     
  Misses          2        2              
  Partials        1        1
Flag Coverage Δ
go- 97.50% <ø> (-0.03%) :arrow_down:
go-1.17 97.50% <ø> (-0.03%) :arrow_down:
go-1.18 97.50% <ø> (-0.03%) :arrow_down:
go-1.19 97.50% <ø> (-0.03%) :arrow_down:
go-1.20 97.50% <ø> (-0.03%) :arrow_down:
macos-latest 97.50% <ø> (-0.03%) :arrow_down:
ubuntu-latest 97.50% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
logger.go 96.51% <ø> (-0.05%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more