search

gin-contrib / logger

Gin middleware/handler to logger url path using rs/zerolog
MIT License
192 stars 35 forks source link

Add benchmark #77

Open cedric-appdirect opened 10 months ago

cedric-appdirect commented 10 months ago

This should help for #69 and #76 and future PR that could affect performance.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.78%. Comparing base (d96c742) to head (60bff74). Report is 8 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #77 +/- ## ========================================== + Coverage 94.24% 94.78% +0.53% ========================================== Files 2 2 Lines 139 115 -24 ========================================== - Hits 131 109 -22 + Misses 5 3 -2 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | Coverage Δ | | |---|---|---| | [go-](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [go-1.18](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [go-1.19](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [go-1.20](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [go-1.21](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [go-1.22](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [macos-latest](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | | [ubuntu-latest](https://app.codecov.io/gh/gin-contrib/logger/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib) | `94.78% <ø> (+0.53%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gin-contrib#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cedric-appdirect commented 10 months ago

Checking the raw logs, it seems even if I set permission for PR to write, it isn't taken into account. From reading around, it seems it would only switch it to write if it get merged into master first, but I am not certain of that. No idea how to tests this further at the moment.

cedric-appdirect commented 7 months ago

Seems you need to check your Settings > Actions > General > Workflow permissions, and make sure to enable read and write permissions for this action to actually work.