gin-gonic / gin

Gin is a HTTP web framework written in Go (Golang). It features a Martini-like API with much better performance -- up to 40 times faster. If you need smashing performance, get yourself some Gin.
https://gin-gonic.com/
MIT License
78.02k stars 7.97k forks source link

GetUint and GetUint64 wrong return #3927

Open bayaderpack opened 5 months ago

bayaderpack commented 5 months ago

Description

I'm trying to use GetUint64 and GetUint but it returns 0

How to reproduce

package main

import (
    "github.com/gin-gonic/gin"
)

func main() {
    g := gin.Default()
    g.GET("/hello", func(c *gin.Context) {
        c.String(200, "Your ID is %d %d", c.GetUint64("user"), c.GetUint("user"))
    })
    g.Run(":9000")
}

Expectations

$ curl http://localhost:9000/hello?user=1
Your ID is 1 1

Actual result

$ curl -i http://localhost:9000/hello?user=1
Your ID is 0 0

Environment

RedCrazyGhost commented 5 months ago

There is a problem with your usage, you should use BindQuery or ShouldBindQuery.

package main

import (
    "net/http"

    "github.com/gin-gonic/gin"
)

func main() {
    g := gin.Default()
    g.GET("/hello", func(c *gin.Context) {
        m := make(map[string]string)
        if err := c.BindQuery(&m); err != nil {
            c.String(http.StatusInternalServerError,"input data have error: %v",err)
            return 
        }
        c.String(http.StatusOK,"input data: %v",m["user"])
    })
    g.Run(":9000")
}

If you use c.Get, you need to use your c.Set in context

package main

import (
    "net/http"

    "github.com/gin-gonic/gin"
)

func main() {
    g := gin.Default()
    g.GET("/hello", func(c *gin.Context) {
        c.Set("user",999)
        c.String(http.StatusOK,"user id: %d",c.GetInt("user"))
    })
    g.Run(":9000")
}