search

gin-gonic / gin

Gin is a HTTP web framework written in Go (Golang). It features a Martini-like API with much better performance -- up to 40 times faster. If you need smashing performance, get yourself some Gin.
https://gin-gonic.com/
MIT License
79.17k stars 8.03k forks source link

c.SaveUploadedFile permissions #4068

Open reversersed opened 1 month ago

reversersed commented 1 month ago

Description

I run into problem when I saving uploaded file to a folder and trying to get it from nginx it gives me permission error. I found out that folders created by SaveUploadedFile function has 0750 rights, which I can't get access to. After changing folder permissions problem is gone. Is there some way to specify the permissions for folders created besides manually creating it or chaning permissions by hand?

How to reproduce

package main

import (
    "github.com/gin-gonic/gin"
    "net/http"
)

func main() {
    g := gin.Default()
    g.POST("/upload", func(c *gin.Context) {
            form, _ := c.MultipartForm()
                file := form.File["file"]

        c.SaveUploadedFile(file, "data/files/img.png")
                c.Status(http.StatusCreated)
    })
    g.Run(":9000")
}

Expectations

I excepted there is some method that allows to specify folder permissions I need (e.g. SaveUploadedFile(file *multipart.FileHeader, dst string, perm ...os.FileMode)). You could specify permissions you need or leave it empty and get default (as it now) permissions.

Actual result

I got hard-written permissions made by source code:

if err = os.MkdirAll(filepath.Dir(dst), 0750); err != nil {
        return err
    }

Environment

haesuo566 commented 1 month ago

Are you saying that we need a method that can provide additional permissions to the SaveUploadedFile method?

reversersed commented 4 weeks ago

Are you saying that we need a method that can provide additional permissions to the SaveUploadedFile method?

We could have an additional method like SaveUploadedFileWithPermission which can allow us to decide what permissions we need for file are. Or just modify existing method adding 3rd parameter allowing us to override default permissions. The details is up to maintainers.

haesuo566 commented 3 weeks ago

Are you saying that we need a method that can provide additional permissions to the SaveUploadedFile method?

We could have an additional method like SaveUploadedFileWithPermission which can allow us to decide what permissions we need for file are. Or just modify existing method adding 3rd parameter allowing us to override default permissions. The details is up to maintainers.

Can i work this issue?

reversersed commented 3 weeks ago

Are you saying that we need a method that can provide additional permissions to the SaveUploadedFile method?

We could have an additional method like SaveUploadedFileWithPermission which can allow us to decide what permissions we need for file are. Or just modify existing method adding 3rd parameter allowing us to override default permissions. The details is up to maintainers.

Can i work this issue?

Well, ofc, it's all up to you