gin66 / FastAccelStepper

A high speed stepper library for Atmega 168/328p (nano), Atmega32u4, Atmega 2560, ESP32, ESP32S2, ESP32S3, ESP32C3 and Atmel SAM Due
MIT License
282 stars 67 forks source link

Developed RMT support for Esp32s3 #225

Closed GarmischWg closed 5 months ago

GarmischWg commented 5 months ago

Tested with 6 steppers only, with a shared enable pin. I don't have 8 steppers.

Only line 2 in StepperISR_esp32_rmt.cpp is intentionally changed, the other changes is caused by the auto formatter.

gin66 commented 5 months ago

Thanks for the PR.

Apparently the espressif lib has been updated and now causing a build error on github actions. I really need to fix it to a specific release in platformio.ini for all esp32 targets and not only some. And need to change the title in build_examples_esp32.yml

GarmischWg commented 5 months ago

FYI, my setup:

for this setup, compilation was successful for esp32s3

GarmischWg commented 5 months ago

From what i saw, it is just a warning, saying that a function in esp32-hal-uart.c should return bool instead of void. But we didn't write that function.... It is inside arduinoespressif32 framework. Is it possible to ignore that warning?

gin66 commented 5 months ago

I will deal with it in a couple of days. for now I will just merge it, so you do not need to wait.

GarmischWg commented 5 months ago

it is ok, i prefer that the development is not rushed, i can just use my local updated version of fastAccelLibrary first.

If people suddenly start raising issues about the new update, just revert it. (Hopefully this doesn't happen).

gin66 commented 5 months ago

Your rmt driver is now included in 0.30.11. Thanks for the patch