search

ginader / easychirp

easychirp.com - Web accessibility for the Twitter website application
11 stars 1 forks source link

Add "Get Older Tweets" to rest of pages #131

Closed weboverhauls closed 10 years ago

weboverhauls commented 10 years ago

"Get Older Tweets" is on Timeline but needs to be added to:

Mentions Favorites RT timelines List timeline Search Results My Tweets

weboverhauls commented 10 years ago

Can you make this your next task, dude?

weboverhauls commented 10 years ago

Hey, I'm figuring out how to do this. But in the tweet fragment, not sure of the best way to make the path below dynamic; so that the link of "Get Older Tweets" returns to the current page rather than the hard-coded /timeline/. Can you help?

    <div class="box1 rounded load-more">
        <a href="/timeline/<?php echo $last_id; ?>" class="button load_more" >Get Older Tweets</a>
    </div>
andrewwoods commented 10 years ago

updating the path is only part of the issue - it's just adding a conditional and a default value. The other part is I'll need to update the controller functions like 'mentions' and 'favorites' (see the above list) to accept the latest tweet id as a parameter as well as adding corresponding routes.

weboverhauls commented 10 years ago

I think I have it all figured out; just need the mechanism for changing the "timeline" in the HREF...

weboverhauls commented 10 years ago

Reminder: I think I can do this task, just need from Andrew the best way to figure out current page for URL in HREF (see above comments).

weboverhauls commented 10 years ago

[Still need pagination on Search Results]