ginader / easychirp

easychirp.com - Web accessibility for the Twitter website application
11 stars 1 forks source link

I18N for names of themes #134

Closed weboverhauls closed 10 years ago

weboverhauls commented 10 years ago

Name of themes are currently hard-coded in the prod/dev config file.

weboverhauls commented 10 years ago

Andrew, I think you misunderstood. The issue is the text "Light Theme" and "Dark Theme" do not get translated. Can you do this?

weboverhauls commented 10 years ago

The XLIFF text nodes are:

<trans-unit id="gbl-theme-light" datatype="html">
<trans-unit id="gbl-theme-dark" datatype="html">
weboverhauls commented 10 years ago

Darn, I tested this locally and it worked fine. I just pushed to prod and it's not working :-(