search

ginetta / skeleton

a static site generator for web frontend projects
22 stars 4 forks source link

Cache-busting on scripts, styles, images and logos. #124

Closed lucalanca closed 7 years ago

lucalanca commented 7 years ago

Only changes references on .html files.

lucalanca commented 7 years ago

What is missing: changing references on css files (of images).

lejoe commented 7 years ago

very nice! Let's merge and test on the website or portfolio?

lucalanca commented 7 years ago

YES 👍 Side note: this doesn't work on image assets referenced on the css. I just checked and that's not the case on either website or portfolio.

lejoe commented 7 years ago

@lucalanca does this mean we should move assets back in the parralle in with styles and scripts: https://github.com/ginetta/skeleton/pull/124/files#diff-b9e12334e9eafd8341a6107dd98510c9R32 ?

Or do you think there's a way to make that work?

lejoe commented 7 years ago

Oh actually you could try this: https://github.com/sindresorhus/gulp-rev#merge Maybe the manifest was overwritten? Also check this thread: https://github.com/sindresorhus/gulp-rev/issues/123#issuecomment-156155960

lejoe commented 7 years ago

There's an error on build: https://app.wercker.com/Ginetta/skeleton/runs/build/58a5cc81eade540100602ef0?step=58a5cc8f9f488e0001ed4a38

lucalanca commented 7 years ago

Yap, I need to rebase this one.

lucalanca commented 7 years ago

Just fixed the issues and rebased.