ging / avatars_for_rails

A Rails gem to manage avatars
MIT License
45 stars 27 forks source link

Rails 3.2 jquery ui 3.0.1 #19

Closed maxstudener closed 11 years ago

maxstudener commented 11 years ago
couldn't find file 'jquery-ui'
  (in /Users/me/.rvm/gems/ruby-2.0.0-p247/gems/avatars_for_rails-1.0.7/app/assets/javascripts/avatars_for_rails.js:2)

needs to be changed to jquery.ui.all

maxstudener commented 11 years ago

for the meanwhile i just took https://raw.github.com/ging/avatars_for_rails/master/app/assets/javascripts/avatars_for_rails.js and overrode the current one in my apps assets/javascripts folder

atd commented 11 years ago

Hi @maxstudener can you please elaborate a little more on the problem?

I understand that you are taking current javascript file to override current javascript file!

maxstudener commented 11 years ago

Because im running rails 3.2 bundler installed avatars_for_rails (1.0.7) If i try to install i higher version like the current version 1.1.4 You get the following error

Bundler could not find compatible versions for gem "jquery-ui-rails":
  In Gemfile:
    rails_admin (>= 0) ruby depends on
      jquery-ui-rails (~> 0.2.2) ruby

    avatars_for_rails (~> 1.1.4) ruby depends on
      jquery-ui-rails (4.0.5)

Bundler could not find compatible versions for gem "actionpack":
  In Gemfile:
    sass-rails (>= 0) ruby depends on
      actionpack (~> 3.1.0) ruby

    rails (= 3.2.13) ruby depends on
      actionpack (3.2.13)

in 1.0.7 avatars_for_rails.js looks like this

  //= require jquery
  //= require jquery-ui
  //= require jquery.Jcrop
  //= require jquery.form
  //= require jquery.fileupload
  // require jquery.fileupload-ui
  //= require flashy

the current version of jquery-ui-rails for rails 3.2 changed from //= require jquery-ui to //= require jquery.ui.all

Which is changed in the newest release of your gem but not the newest version for rails 3.2

atd commented 11 years ago

Our newest release of our gem is the newest version for rails 3.2. We are using it in production in several sites with rails 3.2.14

However, rails 3.2 has nothing to do. It is an issue related to jquery-ui-rails

What can we do to solve this issue?

maxstudener commented 11 years ago

The dependency for rails_admin 0.4.9(latest version for rails 3.2) needs jquery-rails (>= 2.1, < 4) This gem version 1.1.4 needs 'jquery-ui-rails', '>= 4.0.0'

atd commented 11 years ago

Yes, they are incompatible.

I am closing this since the question was not answered. Please reopen if you have a suggestion on what to do.