search

ging / social_stream

A framework for building distributed social network websites
http://social-stream.dit.upm.es/
MIT License
1.13k stars 307 forks source link

Ommit showing images that are filtered from client #174

Closed atd closed 12 years ago

atd commented 12 years ago

Some sites filter requests to content linked from other sites, in order to reduce bandwidth.

This issue affects linker behaviour, because the images are first fetched by linked, but afterwards they are broken in the user-agent.

I propose requesting images in the first place with a referer header.

rafaelgg commented 12 years ago

Fixed by linkser commit c1e85f6

atd commented 12 years ago

This is happening with this link: http://demo-social-stream.dit.upm.es/links/92

rafaelgg commented 12 years ago

This is weird. Most of the time my browser does not load the image, but sometimes....

Hotlinking working?

This also happens if I type the image URL at the browser (i.e. fetch without a referrer): Most of the time I get a 403, but sometimes I just get to see it.

OTOH if I try hotlinking the image:

<html>
<head><title>Image hotlinking test</title></head>
<body>
Try hotlinking the image:
<img src="http://static.amazings.es/media/2012/02/800px-Magnetosphere_rendition-150x150.jpg" />
</body>
</html>

It works! Please notice that this is similar to what linkser does when determining whether to validate an image.

This leads me to believe that said site has some weird referrer policy, maybe with a random element to increase the fun. If this is the case, we should probably blacklist the site and avoid including images from its domain. They obviously don't want us hotlinking their content (which makes me wonder why they are using OpenGraph in the first place).

rafaelgg commented 12 years ago

My bad, hotlinking this pic does not work from any of my sites either (yet sometimes I see it in social_stream demo).

I still don't see why linkser reports it. We'll probably have to debug. Do you have examples from any other domain?

atd commented 12 years ago

Not so far. Things working properly in the rest of cases. Maybe it is their fault, because I also can see it sometimes. We can close this until we have more examples.