gingeleski / cucumber-spring-security-tests

Cucumber/BDD security tests example for Java (Spring Boot API).
9 stars 8 forks source link

The project's current package structure doesn't entirely make sense #40

Closed gingeleski closed 4 years ago

gingeleski commented 4 years ago

Right now, the way packages organize the project leaves something to be desired.

For instance there's a package like cucumber.security which has RestTemplate and non-security configuration stuff in it.

This issue should just be a refactor ("re-package") to address these shortcomings. I imagine with IntelliJ's refactoring features this shouldn't be laborious.

gingeleski commented 4 years ago

Test that the project isn't any more broken than before after the re-packaging. 😉

i.e. gradle assemble should still work smooth, gradle build runs the tests too and like 3 of those fail

gingeleski commented 4 years ago

Need to do src/main still.

I am thinking that from root there'll be a dir like rest or controller then a separate one for domain or models.

gingeleski commented 4 years ago

This is much better now, and further incremental changes can be made as we go about other tasks.

Closing...