gingemonster
commented
5 years ago Hi
To be honest I’m not 100% sure if that would cause and issue or not. Have you tried doing it locally, worth and try and then test it and submit a pull request and I can review
Brian Norman CTO T: +44 (0)845 6429 880 E: brian@earthware.co.ukmailto:brian@earthware.co.uk W: www.earthware.co.ukhttp://www.earthware.co.uk/
[Earthware_Logo_Lock_Up_Small]http://www.earthware.co.uk/
Join our conversation: Bloghttp://www.earthware.co.uk/blog Twitterhttps://twitter.com/earthware LinkedInhttps://www.linkedin.com/company-beta/387715/
This email (including attachments) is confidential and intended only for stated addressee(s). This email is sent on behalf of earthware Limitedhttp://www.earthware.co.uk/, a company registered in England and Wales under registered number 06047986. Earthware’s registered address is 2 Church Barn, Caldecote Road, Newnham, Hertfordshire, SG7 5LA.
From: BamButz notifications@github.com Sent: 02 April 2019 11:25 To: gingemonster/dotnet-opencage-geocode dotnet-opencage-geocode@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [gingemonster/dotnet-opencage-geocode] ResponseObjects in global namespace (#9)
CAUTION: This email originated from outside of earthware.
Hello,
first of all thanks for this great work.
Now to my problem, as far as I can see some objects are in the global namespace that collide with other classes of the same name.
Is it possible to move them into a project specific namespace or would it cause problems that are not known to me?
e.g. dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/License.cshttps://github.com/gingemonster/dotnet-opencage-geocode/blob/14e9eb8fe98a24671c15ca7ee957a7807c1bcb83/OpenCage.Geocode/ResponseObjects/License.cs dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/Annotations.cshttps://github.com/gingemonster/dotnet-opencage-geocode/blob/14e9eb8fe98a24671c15ca7ee957a7807c1bcb83/OpenCage.Geocode/ResponseObjects/Annotations.cs
Bounds is already in a proper namespace so I think it shouldn't be a problem? dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/Bounds.cshttps://github.com/gingemonster/dotnet-opencage-geocode/blob/14e9eb8fe98a24671c15ca7ee957a7807c1bcb83/OpenCage.Geocode/ResponseObjects/Bounds.cs
Best wishes
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/gingemonster/dotnet-opencage-geocode/issues/9, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAq7eIRvm0cMT0yxyWW5TwzvLcUP5-wdks5vcy_ugaJpZM4cXroT.
Hello,
first of all thanks for this great work.
Now to my problem, as far as I can see some objects are in the global namespace that collide with other classes of the same name.
Is it possible to move them into a project specific namespace or would it cause problems that are not known to me?
e.g. dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/License.cs dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/Annotations.cs
Bounds is already in a proper namespace so I think it shouldn't be a problem? dotnet-opencage-geocode/OpenCage.Geocode/ResponseObjects/Bounds.cs
Best wishes