Open john-terenzio opened 5 years ago
I definitely agree. Unless I'm mistaken, the only places where we should be explicitly using JQuery is when we are trying to interact with some Bootstrap behavior via JQuery.
So $('???').tab('show')
would be okay because we are trying to get to .show
provided by Bootstrap. But $(...).on(...)
should be changed because we would want to use regular querySelector
/querySelectorAll
and addEventListener
.
Correct, @john-terenzio ?
https://github.com/ginggk/Ginger-Keys-Web-Rental-Agency/blob/e3788e4b15ed74a767487ab46326b85e2e76b2f6/javaScript.js#L25
I see in some place you are using jQuery via
$
and others plain JavaScript (ex.addEventListener
). I think you should stick with one or the other but not mix them.