search

ginggs / gelemental

periodic table for GNOME
GNU General Public License v3.0
4 stars 7 forks source link

Gelemental should show the element's oxidation states in table view by default. #10

Open artisticfox8 opened 2 years ago

artisticfox8 commented 2 years ago

Gelemental is a very useful application, providing a lot of useful info about elements. Including very useful oxidation states. Many elements have more than one, so they're not obvious from the elements position. Oxidation states is something a chemist needs often when figuring out chemical reaction and in my case (Czech language) names of compounds from their structure. This is the reason traditional paper chemistry tables have this data. So I propose adding this data to the main view, to every element for faster access. I'm currently working on a pull request.

artisticfox8 commented 2 years ago

I already figured out, how to modify the text of the buttons in buttons.cc but I can't figure out where from the properties menu gets it's data from I've tried running grep -rn '/home/artisticfox/Documents/gelemental-master/libelemental' -e 'Oxidation states' and got:

/home/artisticfox/Documents/gelemental-master/libelemental/properties.cc:332:Prop (OXIDATION_STATES, IntList, N_("Oxidation states"), Q_NA,
Binary file /home/artisticfox/Documents/gelemental-master/libelemental/properties.o matches
Binary file /home/artisticfox/Documents/gelemental-master/libelemental/.libs/libelemental.a matches
Binary file /home/artisticfox/Documents/gelemental-master/libelemental/.libs/properties.o matches
Binary file /home/artisticfox/Documents/gelemental-master/libelemental/.libs/libelemental.so.0.0.0 matches

The string I found in properties.cc does not point in any useful direction to find the code to find the element's oxidation states. Can anyone help?

ginggs commented 2 years ago

The string I found in properties.cc does not point in any useful direction to find the code to find the element's oxidation states. Can anyone help?

The data is all in https://github.com/ginggs/gelemental/blob/master/libelemental/data.cc