search

ginglis13 / shortstop

bot for SVS 2020 groupme 🤖
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

detain History #32

Closed joegrip closed 4 years ago

joegrip commented 4 years ago

I added the detain history as per the issue. Not 100% sure it will work. Is there a way to test other than in production?

ginglis13 commented 4 years ago

yea it's hard to test locally unfortunately. a workaround has been to just pass text directly into the function being worked on and see if the output matches what you expect. but it's kind of annoying haha

e: misclicked close my b

joegrip commented 4 years ago

Can I test without the secrets file?

ginglis13 commented 4 years ago

Yes, i believe the 'secret' stuff needed for these functions isn't really necessary, you could just throw gibberish in there.

Also, it might make sense to use JSON for storing history w just key name value number of times detained

joegrip commented 4 years ago

It's all tested and works using json I imported json in detain.py and app.py. I had to do that in testing but not sure if needed for produciton