gingram / slimdx

Automatically exported from code.google.com/p/slimdx
0 stars 0 forks source link

Error in BoundingBox.Contains(BoundingBox, BoundingFrustum) #210

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It uses BoundingBox.Intersects(BoundingFrustum, BoundingBox), which is 
based on BoundingBox.Contains(BoundingBox, BoundingFrustum) itself.

By the way, compiler tolds about it:

d:\temp\slimdx\source\math\boundingbox.cpp(115) : warning 
C4717: 'SlimDX::BoundingBox::Contains' : recursive on all control paths, 
function will cause runtime stack overflow

Original issue reported on code.google.com by boris.ja...@gmail.com on 28 Feb 2008 at 10:03

GoogleCodeExporter commented 9 years ago
I'll look into it, as well as the rest of the bounding volume functions. They 
were
done rather quickly, and they are pretty complex, so it's very possible that 
they
contain errors.

Original comment by Mike.Popoloski on 29 Feb 2008 at 12:12

GoogleCodeExporter commented 9 years ago
C4717 is a level one warning, and I don't see the diagnostic on my build. We're 
compiling with /W4, so something is weird here.

Original comment by josh.petrie on 29 Feb 2008 at 4:32

GoogleCodeExporter commented 9 years ago
I'm using VS2008 C++ compiler, probably it can detect more problems in code.

Original comment by boris.ja...@gmail.com on 29 Feb 2008 at 6:15

GoogleCodeExporter commented 9 years ago
I test it right now. It causes stack overflow =(

Original comment by boris.ja...@gmail.com on 2 Mar 2008 at 4:43

GoogleCodeExporter commented 9 years ago
Fixed.

Original comment by Mike.Popoloski on 2 Mar 2008 at 5:44