search

gini / dexter

dexter is a Kubernetes OIDC helper with as much automation as possible
https://blog.gini.net/frictionless-kubernetes-openid-connect-integration-f1c356140937
MIT License
166 stars 29 forks source link

GitHub Support #27

Closed mrauer closed 4 years ago

tlvenn commented 5 years ago

It might be a good idea to update the doc and other parts of the code to add Github support in addition to Google and Azure @mrauer.

tlvenn commented 5 years ago

Hi @mrauer,

Did you actually test that PR ? On my side i do end up with an error:

Failed to write k8s config: Failed to parse token: square/go-jose: compact JWS format must have three parts

And now that I have looked into it, it seems to me that Github does not actually implement OIDC spec so it seems impossible to use it as a provider...

dkerwin commented 5 years ago

Thank you for this PR. I'll have a look but I agree with @tlvenn that it may not work

dkerwin commented 5 years ago

Hey @mrauer,

fyi: once https://github.com/gini/dexter/pull/30 is merged it becomes very easy to add new providers to dexter

dkerwin commented 4 years ago

Not that #30 is merged it is very easy to extend dexter with new providers. Would love to see you implement the first github provider ;-)

tlvenn commented 4 years ago

It's great that the PR was merged but keep in mind that until Github decides to support OIDC, it's not really possible to support it.

dkerwin commented 4 years ago

You are right. Given that it's not possible with Github without something like dex in the middle I'll close this PR