search

gini / dexter

dexter is a Kubernetes OIDC helper with as much automation as possible
https://blog.gini.net/frictionless-kubernetes-openid-connect-integration-f1c356140937
MIT License
166 stars 29 forks source link

Add a command line parameter to communicate back the email that user used for logging in #35

Closed andrewsav-bt closed 4 years ago

andrewsav-bt commented 4 years ago

For integration of other internal tooling it is necessary to know which account was just added to kubeconfig by dexter. Then other tooling may use this information to create, for example, a new context with that user in kubeconfig. Without this it is not possible to guess which of the accounts in kubeconfig was just updated.

This PR adds a new command line parameter -f that allows specifying a file name where dexter would write the email/identity/user just authenticated.

dkerwin commented 4 years ago

@andrewsav-datacom How can we get this fixed?

AndrewSav commented 4 years ago

@dkerwin sorry, I do not understand the question. The obvious answer is "by merging this PR". What's missing?

dkerwin commented 4 years ago

I'd really love to see you integrate the suggestion I made (replacing log.info + sprintf with log.infof). Besides that the PR looks fine.

AndrewSav commented 4 years ago

Where can I see the suggestion?

AndrewSav commented 4 years ago

@dkerwin I've made the change.