search

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs
Other
6 stars 1 forks source link

feat(GiniHealthSDK): Payment Feature Info Screen IPC-102 #460

Closed razvancapra closed 6 months ago

razvancapra commented 6 months ago

Payment Feature Info Screen about the payment feature for each payable invoice Also cotains fixing rounding and bordering of bank icons: https://ginis.atlassian.net/browse/IPC-172

IPC-102 IPC-172

ValentinaIancu-Gini commented 6 months ago

@razvancapra Thanks for the work done!

I left a few suggestions and clarifications.

However, I found some small issues besides those.

  1. After expending to see the answers to the questions, in a random order, and mostly if I start with the last one and after that others, the answer is not entirely visible due to the reusability feature. Some cells may be reused with a smaller size than the size that is needed. Please see the attached screenshots. Screenshot 2024-03-08 at 19 09 24
Screenshot 2024-03-08 at 19 10 00
  1. Another issue, which might not be an issue but I want to confirm it, is when I select to pay the invoice. On one device I received an error even if I installed both apps needed for this. And on another device, the list of providers seemed too long and I wanted to scroll but I ended up selecting a new provider, also I was stuck in the payment screen. Please see the videos attached and if this is not an issue ignore my comment.

https://github.com/gini/gini-mobile-ios/assets/132361182/c4a043b2-9bb1-440e-bb82-1e1874b665c2

https://github.com/gini/gini-mobile-ios/assets/132361182/8d342971-51ba-4941-b501-d99cf222589e

  1. Switching to German the [LINK] text is not replaced and "Pay bills easily with the banking app." Simulator Screenshot - iPhone SE (1st generation) - 2024-03-08 at 19 40 26

  2. Tapping multiple times on the + icon to expand/collapse the question to see the answer the table view content offset is growing.

    Screenshot 2024-03-08 at 19 44 51

The last remark is that on the iPhone SE first generation, the Back button text is missing while switching to German. Maybe because is longer than in English: Zurück vs Back.

https://github.com/gini/gini-mobile-ios/assets/132361182/20bf0a87-e223-4604-b77d-dc5282cbb7b5

razvancapra commented 6 months ago

@ValentinaIancu-Gini Regarding the 4 issues reported:

  1. Fixed 👍
  2. The banks picker from Payment Review Screen is going to be remove in the next PR. The error shown is a server error received from API when requesting invoice extractions to review in Payment Review screen. Can't reproduce yet.
  3. fixed 👍
  4. fixed 👍