feat(GiniMerchantSDK): Refactoring for images assets

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs

Other

6 stars 1 forks source link

feat(GiniMerchantSDK): Refactoring for images assets #547

Closed motokotomax closed 2 weeks ago

motokotomax commented 3 weeks ago

Proposition to refactor: move all image names to enum, fix naming with common pattern

all strings with file names in one place
remove optional
add fatal error if SDK developer didn't add image resource
common prefix to avoid resource collisions
less code in Utils

ValentinaIancu-Gini commented 3 weeks ago

@motokotomax super nice. We already discussed to do same GiniImage enum in GiniBankSDK for now. Maybe we should think of doing or at least planning to do the package with shared code asap. I see a lot of duplicated code.

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud