search

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs
Other
6 stars 1 forks source link

Pp 51 delivery skonto i os #559

Closed mrkulik closed 3 days ago

ValentinaIancu-Gini commented 2 weeks ago

simulator_screenshot_EBB42694-7CE9-4BB3-B95A-7B6C34FE7940

@mrkulik can you check why is the currency symbol displayed in stead of the "EUR" text? As well for the "full amount" we should display the EUR text near the sum.

ValentinaIancu-Gini commented 2 weeks ago

@mrkulik We need to handle the scroll of the content on small devices. Please see the screenshot attached.

Screenshot 2024-07-03 at 12 16 36
ValentinaIancu-Gini commented 2 weeks ago

@mrkulik I think we should remove the first responder for any editable fields when switching between with or without Skonto. See the video:

https://github.com/gini/gini-mobile-ios/assets/132361182/df1171ac-2023-4689-a694-5a81f42ebe0d

ValentinaIancu-Gini commented 2 weeks ago

@mrkulik please also check Snoarcloud issues. Some of them I already mentioned in my code review but some not like: unused method private func recalculatePrices() {.

ValentinaIancu-Gini commented 2 weeks ago

I found a weird scenario when the user introduces a value for with skonto field and taps on the switch to disable skonto, the input from that field is prefilled in the total amount. See the video recording attached. https://github.com/gini/gini-mobile-ios/assets/132361182/0aeff336-e72e-4110-a3cb-98d3958307ce

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.8% Duplication on New Code

See analysis details on SonarCloud