search

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs
Other
6 stars 1 forks source link

PP-523 fix camera issue when going back from help screen #612

Closed igor-gini closed 1 month ago

igor-gini commented 1 month ago

Prevent reinitializing camera every time it gets opened until it gets deallocated

zladzeyka commented 1 month ago

@igor-gini that you for the PR, I've started with tests and discovered a scenario where the camera is not initialised when I click detect icon or add pages buttons. https://github.com/user-attachments/assets/4edd72ae-32ab-41fc-b302-3975565c1f55

igor-gini commented 1 month ago

@zladzeyka I've addressed it in another fix today

zladzeyka commented 1 month ago

@igor-gini could you please run the unit tests locally Since you've extended protocol CameraProtocol: AnyObject you need to update the tests. scheme is GiniCaptureSDKTests

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
13 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.5% Duplication on New Code

See analysis details on SonarCloud