search

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs
Other
6 stars 1 forks source link

PP-161 fix separator in the last cell #644

Open igor-gini opened 2 weeks ago

igor-gini commented 2 weeks ago

Fixed the separators issue, seems to be all good now ‌

Regarding that “changing background color is unsupported“ issue: it seems that it happens with AlbumsHeaderView (the warning seems to disappear when I comment it out), but I don’t see it setting the background color anywhere, the only place where background color is set there are the viewcontroller’s view background color and table view’s background color, which don’t seem to be causing the issue. I think it could be the NIB file setting it and causing the warning to appear, since AlbumsHeaderView gets loaded from NIB

igor-gini commented 1 week ago

When you have a couple of albums and add one more The delimiter between 1 and 2 will disappear

It's likely because the default separator inset isn’t set anywhere, and after it’s set to be not visible, nothing sets it back. Added setting default inset in setUp of the AlbumsPickerTableViewCell

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud