search

gini / puppet-archive

Puppet Module to download and extract tar.gz, tar.bz2, tar.xz, and zip archives
6 stars 22 forks source link

Problem using module when my class adds a package also added by archive::prerequisites e.g. curl #15

Closed marcusphi closed 10 years ago

marcusphi commented 10 years ago

Maybe add something like if !defined(Package['curl']) { ... } in archive::prerequisites for all packages.

It seems unnecessary having to provide a full custom dependency_class and keep that in sync with archive::prerequisites.

fedecz commented 10 years ago

what about using stdlib's ensure_package('curl') ?

joschi commented 10 years ago

@fedecz I would actually prefer this solution but it seems there are a lot of people trying to avoid the use of puppetlabs/stdlib at all costs and wouldn't be happy if we introduced this dependency.

fedecz commented 10 years ago

@joschi Alright, I understand what you mean, but may I ask why is people trying to avoid puppetlabs/stdlib's ? I'm using it in a very large project and now I'm afraid that i'm missing something :)

marcusphi commented 10 years ago

I've read up on the duplicate package problem within the context of shared modules. It's a tricky problem. A good discussion is https://groups.google.com/d/topic/puppet-users/OF_WYN41dMI

I will close this issue. I think stdlib is good but I'm not convinced ensure_package is a good solution. Current state is ok.