search

gini / puppet-archive

Puppet Module to download and extract tar.gz, tar.bz2, tar.xz, and zip archives
6 stars 22 forks source link

Bug: Symlinks checked into github repo causes build failures in downstream rspec-system tests #6

Closed justenwalker closed 10 years ago

justenwalker commented 11 years ago

Commit 4b6832eaf introduces symlinks into the repository which makes rspec-system tests that include this module fail when copying modules to the test system (Errno::ENOENT). This is because the symlinks reference directories which do not exist in the cloned repository. (lib and files folder)

These symlinks are temporary artifacts of the testing process and should not be in source control.

justenwalker commented 11 years ago

I suggest that you look at puppetlabs/puppetlabs_spec_helper which allows you to specify dependencies using .fixtures.yml and it will clean these up after the build passes.

joschi commented 10 years ago

Merged in #11.