gini / puppet-archive

Puppet Module to download and extract tar.gz, tar.bz2, tar.xz, and zip archives
6 stars 22 forks source link

prerequisties class to install dependant packages needed for extraction #7

Closed bmurtagh closed 10 years ago

bmurtagh commented 11 years ago

Addresses #5. Let me know what you think

joschi commented 10 years ago

Thanks for opening the PR!

Rather than having a boolean value ($install_dependencies) I'd rather have a dependency class directly provided. This way the user of this class could just provide a custom class which installs the prerequisites.

joschi commented 10 years ago

I've added a parameter for providing a dependency class in 0f133ab5629a6adf2030e943371321ba642fe634.

@bmurt Would this meet your requirements?

bmurtagh commented 10 years ago

Yeah, that looks good to me.

joschi commented 10 years ago

Cool, in this case I'll close this PR. Thanks for reporting the issue!