Closed reaganchisholm closed 8 months ago
Great job. I'm going to merge later today. Magnify is indeed a problem and is subject to change. I think on the PTR the wording has changed, yet the colon still stays. For the item name we can solve for all languages as follows
getPerkData
function. Inside the buildItem
function we can use that data to generate the localized item name, unless the item has IgnoreNameChanges
set to true. Using that name, we should get a better match on name.
As discussed in Discord, this PR improves item scanner reliability (#10) as well as a few other updates. It should now recognize most expansion items minus Artifacts (I think we can fix this now that we get the item name consistently)
PR includes:
The biggest change is images now go through processing step after getting uploaded before being passed to the identifying function, we apply grayscale and a curve effect and then draw black squares over specific parts of the image to hide visual noise that confuses tesseract.
Example of what this looks like:
Some areas that can be further improved:
Even with those areas that could be improved, I think this should help improve the consistency for users. Let me know if you'd like any changes or adjustments, or feel free to change anything needed.