giniedp / nw-buddy

New World Buddy App
MIT License
33 stars 10 forks source link

Improve item scanner #11

Closed reaganchisholm closed 8 months ago

reaganchisholm commented 8 months ago

As discussed in Discord, this PR improves item scanner reliability (#10) as well as a few other updates. It should now recognize most expansion items minus Artifacts (I think we can fix this now that we get the item name consistently)

PR includes:

The biggest change is images now go through processing step after getting uploaded before being passed to the identifying function, we apply grayscale and a curve effect and then draw black squares over specific parts of the image to hide visual noise that confuses tesseract.

Example of what this looks like: importer-solution-example

Some areas that can be further improved:

Even with those areas that could be improved, I think this should help improve the consistency for users. Let me know if you'd like any changes or adjustments, or feel free to change anything needed.

giniedp commented 8 months ago

Great job. I'm going to merge later today. Magnify is indeed a problem and is subject to change. I think on the PTR the wording has changed, yet the colon still stays. For the item name we can solve for all languages as follows