ginkage / MHI-AC-Ctrl-ESPHome

ESPHome integration for MHI-AC-Ctrl project
MIT License
95 stars 35 forks source link

Home Assistant 2023.7 requires a setting to make service calls from ESPHome #59

Closed ervee closed 1 year ago

ervee commented 1 year ago

With pull https://github.com/home-assistant/core/pull/95143 for Home Assistant 2023.7, they now require a setting per ESPHome device to allow service calls.

In lr_mhi_ac_ctrl.yaml you use a call to set_api_room_temperature. So in case anyone uses this for new devices starting Home Assistant 2023.7 you need to enable the ESP device to make the service call. image

Perhaps update the yaml example and/or the main README with a note?

arpiecodes commented 1 year ago

As far as I understand this new feature, it's for calling services at HA from devices, not from HA to devices. The set_api_room_temperature is actually a service exposed by the device, not HA. So this option does not have to be enabled for the 'use case' to update room temp from HA.

JoepWi commented 1 year ago

I can confirm that set_api_room_temperature just works fine. As @arpiecodes states. The new functionality had to do with info going back from devices as an answer to specific HA call.

ervee commented 1 year ago

Great. Thanks for the confirmation!

ervee commented 1 year ago

Close

ervee commented 1 year ago

Woops