Use native CMake variables for compiler flags

ginkgo-project / ginkgo

Numerical linear algebra software package

https://ginkgo-project.github.io/

BSD 3-Clause "New" or "Revised" License

401 stars 88 forks source link

Use native CMake variables for compiler flags #1535

Closed upsj closed 7 months ago

upsj commented 8 months ago

Pulled out of #1334, this uses the natively supported CMAKE_<LANG>_FLAGS variables instead of our custom variables and sets them in CI instead of CMake, which is discouraged in its genericity, since -Wpedantic is only supported in gcc-like compilers.

The custom variables are not necessary, because they can instead be handled by appropriately scoped CMake variables

TODO:

[x] update README instructions for SYCL

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud