Expand hipSPARSE bindings for complex types

ginkgo-project / ginkgo

Numerical linear algebra software package

https://ginkgo-project.github.io/

BSD 3-Clause "New" or "Revised" License

401 stars 88 forks source link

Expand hipSPARSE bindings for complex types #1538

Closed nbeams closed 7 months ago

nbeams commented 8 months ago

hipSPARSE has improved its complex support, so we can add complex types to these routines.

pratikvn commented 7 months ago

We dont test any of these. Maybe we should think about having capabilities to more comprehensive typed unit tests ? Probably not to run with our regular CI, as that would consume too much time, but something that we could run if necessary, or maybe before a release to ensure that all types work well.

upsj commented 7 months ago

Tagging #534 here. I don't agree that testing all of them is too much of a burden, one full HIP GPU pipeline I just ran on FTP takes only 3-4 minutes when built in Release shared. I think instead we should consider cutting down on our debug and static builds and/or using our FAST_TESTS flag in more places.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud