search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
401 stars 88 forks source link

Allow to optionally use C++17 #1548

Closed MarcelKoch closed 5 months ago

MarcelKoch commented 7 months ago

Based on: #1544

This PR allows to optionally use C++17. If the CMake option CMAKE_CXX_STANDARD is set, this will be the standard that is used to compile ginkgo. If this option is not used, then the highest available standard between c++14, c++17 will be used.

Additionally, the macro GINKGO_HAVE_CXX17 will be set to true or false, depending on the standard.

Exception: DPCPP will still use C++17, and I have no idea of how the HIP setup works, but I'm guessing that it will ignore this.

PR Stack:

MarcelKoch commented 5 months ago

This PR is not required anymore. If we decide at a later point to enable c++17 optionally we can revive this.