search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
401 stars 88 forks source link

need sycl::ctz for Aurora 2023.12.30.002 #1559

Closed pwxy closed 7 months ago

pwxy commented 7 months ago

When building on Aurora, sycl::ext::intel::ctz is OK for oneapi/eng-compiler/2023.10.15.002, but not for oneapi/eng-compiler/2023.12.30.002 (build will fail) For oneapi/eng-compiler/2023.12.30.002, need sycl::ext::intel::ctz -> sycl::ctz sycl::ctz is fine for 2023.10.15.002

I am unable to test any on other SYCL platform.

pwxy commented 7 months ago

Doesn't look like I can request reviewers, otherwise I would have requested Pratik Nayak.

upsj commented 7 months ago

Tagging #1396 here, which contains the same fixes plus a few other deprecation fixes. I think we should get rid of those remainders of old oneAPI versions, since they clog up our build outputs unnecessarily

pratikvn commented 7 months ago

Thank you @pwxy for creating the PR and the fixes. It seems that #1396 from @upsj already incorporates these changes. IMO, we can drop support for the older SYCL versions. We will try to merge that PR soon.

upsj commented 7 months ago

There are some additional issues with the latest oneAPI version, so I'll do that in #1396 and close this PR