search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
384 stars 86 forks source link

HIP platform detection with hipconfig is not sufficient #1565

Closed lahwaacz closed 2 months ago

lahwaacz commented 3 months ago

cmake/hip.config contains some code to auto-detect hipconfig location:

https://github.com/ginkgo-project/ginkgo/blob/f952c6eb1c0bb79b68f1c7ec03e5f20052f72d48/cmake/hip.cmake#L109-L124

However, at the top of this file, either HIP_PLATFORM envvar or GINKGO_HIPCONFIG_PATH cmake variable is required:

https://github.com/ginkgo-project/ginkgo/blob/f952c6eb1c0bb79b68f1c7ec03e5f20052f72d48/cmake/hip.cmake#L1-L9

The documentation also says that the HIP platform is auto-detected and does not mention GINKGO_HIPCONFIG_PATH at all.

upsj commented 3 months ago

This will likely be made redundant by #1334